Patch policy -- bug 6318 ?

Tim Prouty tprouty at samba.org
Tue May 5 19:25:57 GMT 2009


On May 5, 2009, at 11:46 AM, Jeremy Allison wrote:

> On Tue, May 05, 2009 at 04:32:17PM +0200, Volker Lendecke wrote:
>> Hi!
>>
>> In bug 6318 Michael posted a patch that fixes some bug. He
>> ported back a series of 4 patches that also do some good
>> refactoring in master/3.4. However, for 3.3 there could be a
>> much smaller patch that also fixes the problem without the
>> refactoring. The refactoring consolidates code and includes
>> a lot of "-" in the patch, but it's larger than strictly
>> necessary.
>>
>> What kind of patch do we want for 3.2/3.3?
>
> Personally I'd rather go for the smaller patch
> without the refactoring, and keep the refactoring
> in the unreleased branches. IMHO we should be trying
> to do point patches only for specific bugs in the
> 3.3/3.2 code trees. Just my 2 cents.

I agree.  To ensure the stability of maintenance releases, we should  
be adding the minimum code necessary to fix the bug.

-Tim


More information about the samba-technical mailing list