[SCM] Samba Shared Repository - branch master updated
Volker.Lendecke at SerNet.DE
Mon May 4 19:25:54 GMT 2009
On Mon, May 04, 2009 at 12:22:48PM -0700, Tim Prouty wrote:
> >On Mon, May 04, 2009 at 11:58:19AM -0500, Tim Prouty wrote:
> >>- if (fnum1 != -1) cli_close(cli1, fnum1);
> >>- if (fnum2 != -1) cli_close(cli2, fnum2);
> >>+ cli_close(cli1, fnum1);
> >>+ cli_close(cli2, fnum2);
> >I think that's wrong. We need a (fnumx 1= (uint16_t)-1).
> I was just mirroring the other usage in the file as the quick warning
> fix. It seems a little bit strange to me to make an fd uint, when the
> standard api uses -1 to indicate error.
Which other usages do you mean?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090504/969508b9/attachment.bin
More information about the samba-technical