Backport to 3.3 of bug fix for #6315 smbd crashes doing vfs_full_audit on IPC$ close event

simo idra at samba.org
Mon May 4 17:36:56 GMT 2009


On Mon, 2009-05-04 at 08:50 -0700, Jeremy Allison wrote:
> On Mon, May 04, 2009 at 05:48:54PM +0200, Volker Lendecke wrote:
> > On Mon, May 04, 2009 at 08:35:57AM -0700, Jeremy Allison wrote:
> > > Hi Karolin,
> > > 
> > > I'd like to have the attachment to bug #6315 pushed into
> > > the 3.3 tree. The attachment is here.
> > > 
> > > https://bugzilla.samba.org/attachment.cgi?id=4100&action=view
> > > 
> > > But I need someone else to sign off on this first please.
> > > So this is a request for someone else to review this fix :-).
> > 
> > I don't know if this is the right way to fix it. Sorry, I
> > was busy today with other stuff, I need to take a look at it
> > first. I have the gut feeling that the fix should be simpler
> > without this free_if_unused routine.
> 
> Well the commit message I added for master and 3.4 is
> very long and explains why I added the free_if_unused()
> function. I spent a long time on this one so I'll understand
> if you take your time but I'm pretty convinced the fix is
> as simple as it needs to be :-).

And also very, very ugly :-)

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list