[PATCH] Have the smbcli_session record the OS and Native LANMAN of the remote server

[simo]

On Fri, 2009-05-01 at 16:15 +0200, Stefan (metze) Metzmacher wrote:
> We clearly need to combine, update and improve our coding guides.
> 
> At least for me it would make sense to have a rule to
> - do only one thing in one line.
> - don't assign variables within if statements
> - don't call functions as function parameters, use helper variables.
> 
>   functiona(functionb()) is bad
> 
> - prefer using
>   if (x == y) {
>       return;
>   }
>   instead of
>   if (x == y)
>       return;

+1, if most agree we should update the coding style guidelines.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>