patch: add cups encryption support

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Mar 27 12:34:46 GMT 2009


On Fri, Mar 27, 2009 at 01:13:27PM +0100, Björn JACKE wrote:
> can someone please review
> 
> http://repo.or.cz/w/Samba/bjacke.git?a=commit;h=4d864a6f59856f2618ec7e0abb10f4d283c304ee
> http://repo.or.cz/w/Samba/bjacke.git?a=commit;h=b421d5147a0e5a7aa18438604a489fc4234f9371
> 
> and pull to master if appropriate?

A quick search for httpConnectEncrypt found

http://webui.sourcelabs.com/cups/mail/dev/threads/How_to_get_printer_status_via_CUPS_API%253F.meta

This contains

> > BTW. httpConnectEncrypt() calls httpInitialize() which
> > calls gnutls_global_init() but httpClose() or any other
> > function do not call gnutls_global_deinit() which would
> > free the acquired resources. This is true for atleast CUPS
> > 1.3.7. See: http://linux.die.net/man/3/gnutls_global_init
> 
> This is OK - we only want/need to initialize once, and then the
> resources are freed automatically when the process exits.

Samba calls httpClose(). Is it certain that we don't end up
with a memory leak here?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090327/f622bc91/attachment.bin


More information about the samba-technical mailing list