Challenges in merging the charcnv code

[Andrew Bartlett]

On Thu, 2009-03-26 at 21:18 +0100, Volker Lendecke wrote:
> On Thu, Mar 26, 2009 at 06:50:13AM +1100, Andrew Bartlett wrote:
> > Based on the above I no longer propose for merging the full patch stream
> > to use the common charcnv engine.  I present for the consideration of
> > the Samba3 team a rebased patch series to remove the _allocate() charset
> > APIs and some other small changes to make it easier for someone else to
> > take this task on at some future time:  
> 
> Quick question: Why does smbldap_talloc_dn return a const
> char * instead of just a char *? In my build this creates
> quite a few const warnings. Would you mind if that would be
> changed to char *?

I don't mind - it's not actually a new function, so I wasn't of the mind
to change it.  

The other approach (which I probably should have taken) would have been
to allocate a temporary talloc context for the result to be on, and
talloc_free() that. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090327/c1f0a642/attachment.bin