[PATCH] Setting nTSecurityDescriptor via LDAP fails

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Metze,

Stefan (metze) Metzmacher wrote:>
> why does PyObject_AsMessageElement() copy the string for one case but
> not for the multiple value case.
Good point; since we borrow the reference to the list, we don't need to
do a dup there at all.

> Also why doesn't it use a->syntax->ldif_read_fn() as
> PyObject_FromLdbValue() also uses a->syntax->ldif_write_fn().
PyObject_FromLdbValue() probably shouldn't be using
a->syntax->ldif_write_fn().

> I wonder why we only handle ldif correctly in samba.Ldb and not in
> the LDB.Ldb class.

LDB.Ldb doesn't load any of the Samba-specific code, including nt
security descriptor handling.

I'll have a look at Zahari's patches and these issues later today.

Cheers,

Jelmer
>> I am sending again the patch for nTSecurityDescriptor bug with LDAP
>> (null character '\0' issue in the middle of object property value).
>>
>> Hope it is OK now.
> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iJwEAQECAAYFAknDlBAACgkQDLQl4QYPZuUUKAP/S1SAGS98BuzzvVL7BHOHZrgp
hiePZrtOgE312K6zZz1cvLyAp63jpaLFrB9xkXiMxIdPcDgZNBpMHGoE+Od8J2y6
MP12P+017KT4BV+DWmRXqM2YDi5YFP8SlqYROCd1UiPphRDbY6bytlluZbYkEG2T
eAh4N9oeRiGs0Z+n3kw=
=ED/W
-----END PGP SIGNATURE-----