[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-557-gd380c49

Stefan (metze) Metzmacher metze at samba.org
Fri Mar 20 08:46:43 GMT 2009


tridge at samba.org schrieb:
> Hi Metze,
> 
> I see you've already changed this. Would you mind reverting it or just
> removing the whole nesting value check?
> 
> The code now does this:
> 
>    uint32_t level;
> 
>    level++;
> 
>    if (level > 0) {
>      call_hook();
>    }
> 
> 
> just as a matter of simple logic this means that 'level' is completely
> redundent.

Yes, for the nesting hook it level > 0 now always true,
I just wanted to discuss with you if I should change that check to
level > 1, or if we remove the check completely. That why I made it a no
op for now. I think we should remove it completely.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090320/439e4735/signature.bin


More information about the samba-technical mailing list