[SCM] Samba Shared Repository - branch master updated
- release-4-0-0alpha7-565-g88dd6af
Stefan (metze) Metzmacher
metze at samba.org
Thu Mar 19 15:36:55 GMT 2009
Volker Lendecke schrieb:
> Hi, Metze!
>
> On Thu, Mar 19, 2009 at 08:02:57AM -0500, Stefan Metzmacher wrote:
>>
>> + bytes = TALLOC_ARRAY(talloc_tos(), uint8_t, 0); /* padding */
>> + if (bytes == NULL) {
>> + goto fail;
>> + }
>> +
>
> Is this right? Long ago we had the big debate about
> talloc(0) returning NULL or not. I don't remember the real
> outcome, but we still have the comment
This code is correct.
>> Disable these now we have checked all code paths and ensured
>> NULL returns on zero request. JRA.
>
> in source3/include/smb_macros.h
We're at v3-4-test now and should really remove this unused macros...
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090319/8389c04f/signature.bin
More information about the samba-technical
mailing list