[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-497-g211e255

[Zachary Loafman]

On Wed, Mar 18, 2009 at 07:33:38AM +0100, Stefan (metze) Metzmacher wrote:
> Hi Zach,

Hey!
 
> >  	switch (transport->options.signing) {
> >  	case SMB_SIGNING_OFF:
> > @@ -187,7 +188,7 @@ static void continue_socket(struct composite_context *creq)
> >  	state->negprot.in.capabilities  = 0;
> >  	unix_to_nt_time(&state->negprot.in.start_time, time(NULL));
> >  	dialects[0] = SMB2_DIALECT_REVISION;
> > -	dialects[1] = 0;
> > +	dialects[1] = SMB21_DIALECT_REVISION;
> >  	state->negprot.in.dialects = dialects;
> 
> There was a reason to also provide dialect '0', as I want to work
> against early longhorn beta versions.

Is it important to work against a pre-release version? [MS-SMB2] makes
clear that dialect 0 was only ever sent by pre-release software and has
since been deprecated. If it's important, I'm happy to add it back.
 
> > --- a/source4/libcli/util/nterr.c
> > +++ b/source4/libcli/util/nterr.c
> > @@ -549,6 +549,7 @@ static const nt_err_code_struct nt_errs[] =
> >  	{ "NT_STATUS_OBJECTID_NOT_FOUND", NT_STATUS_OBJECTID_NOT_FOUND },
> >  	{ "NT_STATUS_DOWNGRADE_DETECTED", NT_STATUS_DOWNGRADE_DETECTED },
> >  	{ "NT_STATUS_DS_BUSY", NT_STATUS_DS_BUSY },
> > +	{ "XXX_INVALID_RANGE", NT_STATUS_WIN7_INVALID_RANGE },
> 
> Could you please fix this, and let us display the correct name?

I sent mail to cifs-protocol asking for the "real" name of 0xC00001A1,
but haven't seen a response yet. It's supposed to be documented in
MWS-ERREF. The name is not NT_STATUS_WIN7_INVALID_RANGE. I could not
find a reference to the constant anywhere. 

My intention was to patch the real name and fix the constant once we had
an actual name for it.

...Zach