patch to prevent segmentation fault on joining a very long domain name in samba-3.0.32

[Volker Lendecke]

On Mon, Mar 16, 2009 at 01:21:50PM +0530, Bhaskar Jain (bhajain) wrote:

> Please find the attached patch and please comment/provide your thoughts.

Thanks for that thorough analysis. Your patch looks entirely
correct and is probably the best one if you are out for the
"minimum necessary change".

However, wouldn't it be cleaner to change the type of the
"ptr" function parameter to pull_netlogon_string from "const
char *" to "const uint8 *"? This would make some other casts
in that routine and all the casts in the callers
unnecessary.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090316/f46c2e16/attachment.bin