[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-260-gf088353

[simo]

On Mon, 2009-03-09 at 19:13 -0500, Simo Sorce wrote:
> The branch, master has been updated
>        via  f088353d37b433af7b979a17871233cccddf7aca (commit)
>       from  218ce0e80532b0dbc595e72502d9596a35acdffd (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit f088353d37b433af7b979a17871233cccddf7aca
> Author: Simo Sorce <idra at samba.org>
> Date:   Mon Mar 9 18:04:38 2009 -0400
> 
>     Fix potential segfaults using freed memory.
>     
>     In some code paths ltdb_context was still referenced even after we were returned
>     an error by one of the callbacks. Because the interface assumes that once an
>     error is returned the ldb_request may be freed, and because the ltdb_context was
>     allocated as a child of the request, this might cause access to freed memory.
>     Allocate the ltdb_context on ldb, and keep track of what's going on with the
>     request by adding a spy children on it. This way even if the request is freed
>     before the ltdb_callback is called, we will safely free the ctx and just quietly
>     return.

Uhm while fixing a condition I was seeing here, I might have introduced
a bug in the timeout handling (looking at build farm results). Will try
to repro and fix tomorrow first thing.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>