s3: simplify smb signing code

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Mar 9 16:58:00 GMT 2009


On Mon, Mar 09, 2009 at 05:40:23PM +0100, Stefan (metze) Metzmacher wrote:
> I've simplified the smb_signing code in source3
> (I removed about 1000 lines and added 500 :-)
> 
> It the caller maintains the mid/seqnum mapping the basic
> signing engine is much easier.
> 
> The design a similar to what source4 already has, but I think
> the new code is also a bit easier as the current source4 signing code.
> 
> When we have unified the DEBUG code, we can let source4 also use the new
> code...
> 
> Please review the patches in this branch
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-signing
> 
> I need to do some more testing, but smbclient works against windows and
> samba.

smbclient is easy, it's rpcclient with --enable-developer
that triggers transs. That's the one to get right :-)

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090309/8a0925d6/attachment.bin


More information about the samba-technical mailing list