Re-introduced bugs by merging s3 and s4 :-(

Jeremy Allison jra at samba.org
Sun Mar 8 00:24:50 GMT 2009


On Fri, Mar 06, 2009 at 03:06:02PM +0100, Volker Lendecke wrote:
> Hi, Jelmer!
> 
> On Tue, Mar 03, 2009 at 12:44:22PM +0100, Volker Lendecke wrote:
> > With your merge of convert_string_talloc you re-introduced a
> > bug that we got rid of in S3 long ago: convert_string_talloc
> > and others now take a void ** as destination pointer. This
> > is not portable C.
> > 
> > Can you please revert that merge or fix it properly, not
> > re-introducing bugs again that we fixed in Samba 3?
> 
> Any updates here? Or shall we revert that change?

If it isn't fixed by wed next week I'd just revert it (IMHO).

Jeremy.


More information about the samba-technical mailing list