[linux-cifs-client] [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call

Jeremy Allison jra at samba.org
Wed Mar 4 19:29:07 GMT 2009


On Wed, Mar 04, 2009 at 02:24:30PM -0500, simo wrote:
> On Wed, 2009-03-04 at 13:02 -0600, Steve French wrote:
> > Attached is patch to workaround the problem found in posix open to
> > Samba versions 3.3.1 and earlier
> > (create works, but open would fail with invalid parameter) - it
> > disables requests to try posix open after
> > a first failure.
> 
> Why do you completely disable posix opens ?
> Wouldn't it make sense to reopen only when it fails ?
> After all when you create new files it works correctly.

No, you don't want to do this complexity. Much more
simple to just disable that call if you're running
against a buggy server.

Jeremy.


More information about the samba-technical mailing list