[PATCH] Fix run_events() to run all ready events instead of the first one in the list

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Mar 4 11:16:53 GMT 2009


On Wed, Mar 04, 2009 at 06:49:11PM +0800, boyang wrote:
>       signal events and timer events will affect fd events, and fd
> events can delete itself from the list in the handler. Does it make
> sense to run all ready events of one kind instead of just one? Ie, if
> there is signal events, we run them and return; else run timer events
> and return....

I would really strongly argue against that, I have had quite
a few really trickly to find bugs. If we go there, it will
make debugging crashes a pure nightmare.

For the SerNet packages I will create a patch that removes
it again, like the undo-the-right-thing winbind patch did
until "winbind rpc only" came.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090304/07c54c31/attachment.bin


More information about the samba-technical mailing list