[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-121-g2127566

SATOH Fumiyasu fumiyas at osstech.co.jp
Mon Mar 2 13:41:03 GMT 2009


Hi,

At Mon,  2 Mar 2009 07:13:12 -0600 (CST),
Volker Lendecke wrote:
> commit 212756646efa85880a6b50aa7cb404e402c2ae4a
> Author: Björn Jacke <bj at sernet.de>
> Date:   Sun Mar 1 21:08:33 2009 +0100
> 
>     make man page (un)install more portable

> diff --git a/source4/script/installman.sh b/source4/script/installman.sh
> index ae99bce..a3b6ec0 100755
> --- a/source4/script/installman.sh
> +++ b/source4/script/installman.sh
> @@ -6,7 +6,7 @@ MANPAGES=$*
>  
>  for I in $MANPAGES
>  do
> -	SECTION=`echo $I | grep -o '.$'`
> +	SECTION=`echo -n $I | sed "s/.*\(.\)$/\1/"

The -n option for echo is not portable, and
the last backquote character is missing.

I suggest:

	SECTION=`expr x"$I" : x'.*\(.\)'`

-- 
-- Name: SATOH Fumiyasu (fumiyas @ osstech co jp)
-- Business Home: http://www.OSSTech.co.jp/
-- Personal Home: http://www.SFO.jp/blog/

>  	DIR="$MANDIR/man$SECTION"
>  	if [ ! -d "$DIR" ]
>  	then
> diff --git a/source4/script/uninstallman.sh b/source4/script/uninstallman.sh
> index 72b523e..9b087c6 100755
> --- a/source4/script/uninstallman.sh
> +++ b/source4/script/uninstallman.sh
> @@ -8,7 +8,7 @@ MANPAGES=$*
>  
>  for I in $MANPAGES
>  do
> -	SECTION=`echo $I | grep -o '.$'`
> +	SECTION=`echo -n $I | sed "s/.*\(.\)$/\1/"
>  	FNAME=$MANDIR/man$SECTION/$I
>  	if test -f $FNAME; then
>  	  echo Deleting $FNAME
> 
> 
> -- 
> Samba Shared Repository
> 


More information about the samba-technical mailing list