build patches

simo idra at samba.org
Mon Mar 2 04:02:30 GMT 2009


On Mon, 2009-03-02 at 14:38 +1100, Andrew Bartlett wrote:
> On Sun, 2009-03-01 at 21:16 +0100, Björn JACKE wrote:
> > Hi all,
> > 
> > some volunteer here to push this? :-)
> 
> Isn't there a risk with 
> -       @-find $(samba4srcdir) -name '*.o' -exec rm -f '{}' \;
> +       @-find $(samba4srcdir) -name '*.o' | xargs rm -f
> that the path is no longer quoted?
> 
> You could move to 
> 
> @-find $(samba4srcdir) -name '*.o' -print0 | xargs -0 rm -f 
> 
> But I'm not sure even that is safe (and portable).

I guess this:
	@-find $(samba4srcdir) -name '*.o' -delete
would not be portable ?

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list