Issue with changes to VFS_STAT and VFS_LSTAT.

[Tim Prouty]

On Jun 29, 2009, at 11:04 AM, Jeremy Allison wrote:

> On Mon, Jun 29, 2009 at 10:51:19AM -0700, Tim Prouty wrote:
>
>> Previously there was no correct way at the vfs layer to  
>> differentiate between a
>> filename containing a colon (posix extensions, demangled name) and  
>> a stream as
>> passed over the wire by the windows client.  Now that there is more  
>> detailed
>> information about the filename at the posix level, I fully agree  
>> that this is a
>> good time to diverge from previous behavior.
>
> Yes, but at the POSIX layer we need to error with a non-zero
> stream component.

agreed.

>> In the case of smbd running with no streams modules, I believe your  
>> patch will
>> cause an assert to be fired for every smb_filename-based vfs op.
>
> I don't think it does, only for calls containing a stream name
> from the client.

Yes, you're right.

>> I'm happy to make these changes in my next round of the migration.
>
> Let me look at them first, that way I know there's more
> than you understanding this code :-).

Ok, let me know.  I'm going to work on some of the other vfs calls  
early this week, so if I don't see any precedent from you, I'll add an  
error path in the vfswrap_* versions of the new operations I convert.

>> Also, thank you for following all of these changes!
>>  I'm touching a lot of code, and it's good to know you're keeping  
>> an eye on them :).
>
> Yeah, I'm watching these changes very carefully :-).


Excellent!  Thanks for keeping me honest :)