Review please :-)
idra at samba.org
Mon Jun 15 15:13:09 GMT 2009
On Mon, 2009-06-15 at 17:08 +0200, Volker Lendecke wrote:
> On Mon, Jun 15, 2009 at 10:54:21AM -0400, simo wrote:
> > Or is there something I am missing here ?
> You're missing the direct call to the destructor in winbind3. :-)
Oooh, looks so dirty :/
> But as I had to figure out later, re-using the same event
> context in a forked process seems to work only with the
> select backend. Epoll does not like to be re-used. So I'm
> not sure I still need this, I'm doing some further testing
> right now.
Yeah if there is a "cleaner" approach it might be better, or we risk
getting nasty surprises down the road if the destructor is not called
only when we are going to free ev.
If we need to keep doing it I'd suggest renaming the actual destructor
into something like: tevent_common_context_reset() and have a new
tevent_common_context_destructor() calling it. At least it would make it
clear that tevent_common_context_reset() is used by something other than
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical