SOLVED: Re: CTDB build problem on AIX

[Stefan (metze) Metzmacher]

William Jojo schrieb:
> Stefan (metze) Metzmacher wrote:
>> William Jojo schrieb:
>>  
>>> William Jojo wrote:
>>>    
>>>> William Jojo wrote:
>>>>      
>>>>> The last successful version I built of CTDB was 1.0.77. I tried
>>>>> 1.0.84 then 1.0.82 today and they both fail out trying to find the
>>>>> getopt.h header file.
>>>>>
>>>>>         
>>> Not my best day ever... Here's the correct patch against 1.0.84.
>>>
>>> <snip>
>>> --- ./utils/ping_pong/ping_pong.c.orig  2009-06-03 19:15:51.000000000
>>> -0400
>>> +++ ./utils/ping_pong/ping_pong.c       2009-06-03 19:16:18.000000000
>>> -0400
>>> @@ -37,7 +37,9 @@
>>> #include <string.h>
>>> #include <unistd.h>
>>> #include <fcntl.h>
>>> +#ifndef _AIX
>>> #include <getopt.h>
>>> +#endif
>>> #include <sys/mman.h>
>>>     
>>
>> Why do we need getopt.h at all then?
>>   
> Not sure, but it's part of glibc, so I assumed this was still necessary
> for some Linuxes. Looks like a locking torture test by Tridge and added
> to CTDB tree between 77 and 82. AIX doesn't have that header as the
> portions are already defined in stdio.h, so I just ifdef'd around it for
> the time being.

'man 3 getopt' says getopt.h is only needed for getopt_long() and
getopt_long_only() and getopt() is defined in unistd.h.

maybe we should remove it completely then instead of having system
specific #ifdef's.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090604/228cf544/signature.bin