Remove gen_ndr/* from master?

Jelmer Vernooij jelmer at
Fri Jul 31 18:45:11 MDT 2009

Stefan (metze) Metzmacher wrote:
> Andrew Bartlett schrieb:
>> On Tue, 2009-06-30 at 14:47 +1000, Andrew Bartlett wrote:
>>> I'm wondering if, given we now have a combined tree, including PIDL, if
>>> we could start removing the gen_ndr/* files from master.
>>> Having them in the tree creates a large degree of noise and churn in
>>> GIT, and the potential for partial commits (so that you need to use PIDL
>>> anyway).
>>> I'm sure there is some more history to this than I've recalled.  Is
>>> there any particular reason these files need to be committed into GIT?
>> Does anyone have any views on this?
> I often find it useful to see the diff of the generated code, when I
> change pidl.
You should be able to keep a copy of the old generated code around from
before you made the change and diff against the newly generated code. If
you're relying on "git diff" you don't see all the changes, since not
all of the generated code is checked in.



More information about the samba-technical mailing list