Patch for LDB sort check

[Andrew Bartlett]

On Mon, 2009-07-13 at 01:10 +0400, Matthieu Patou wrote:
> Andrew,
> 
> I resubmit a cleaner (well conforming to samba coding style) patch.
> 
> Please reply if something else has to be changed as I mostly forgot your 
> irc remarks on it ...

Thanks, I do have a few comments (sorry for the delay):

Please rename it to LDAP-SORT (the choice of client lib does not
actually make it different to any other LDAP test).

Also, please do not do:

+       ctrl = talloc_array(ctx, struct ldb_control *, 2);
+       ctrl[0] = talloc(ctrl, struct ldb_control);
+       ctrl[0]->oid = LDB_CONTROL_SERVER_SORT_OID;
+       ctrl[0]->critical = true;

But instead specify no controls, and then call

ldb_request_add_control()

Also, for the actual control:
+       control = talloc_array(ctrl[0], struct ldb_server_sort_control
*, 2);

There is no need for this to be an array.

Finally, Any chance of having this in git-format-patch format?


Thanks,


Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20090723/6794a049/attachment.pgp>