FW: lib/system_smbd.c?: call it only once with max

[Jeremy Allison]

On Mon, Jul 13, 2009 at 04:08:56PM -0400, Yannick Bergeron wrote:
> 
> 
> 
> 
> Hi
> 
> well this is a pretty good purpose to have the original code then :)
> 
> AIX 5.3 and 6.1 has a 128 NGROUPS_MAX value while AIX 5.2 (EOS) has 64
> http://www.j3e.de/ngroups.html
> 
> I'm still trying to reproduce the behavior I'm talking about outside of Samba code to open an AIX PMR
> 
> would this change be more acceptable?
> 
> @@ -151,11 +151,15 @@ bool getgroups_unix_user(TALLOC_CTX *mem_ctx, const char *user,
>      int max_grp;
>      gid_t *temp_groups;
>      gid_t *groups;
>      int i;
>  
> +#ifdef AIX
> +    max_grp = groups_max();
> +#else
>      max_grp = MIN(32, groups_max());
> +#endif

I *hate* #ifdef "OSVERSION" code. Can you make this
a feature test we can check in configure.in instead
please ?

Jeremy.