[PATCH] added missing '\n' to ldb_debug messages
abartlet at samba.org
Thu Jul 9 19:52:24 MDT 2009
On Thu, 2009-07-09 at 17:23 +0200, Sumit Bose wrote:
> this patch adds a few missing '\n' to ldb debug messages to make the
> debug experience more consistent.
I would rather the reverse - that we never specify the \n.
The inclusion of \n in Samba's DEBUG() messages is a hack dating back
years, to do with the way Samba outputs multiple line messages. I don't
think we need to infect ldb with that.
Instead, ldb_debug_stderr() should be patched to output a \n on the end
of the line, as the log format requires. (This message can be
redirected, and may not go to a log, and so should not have the log
formatting oddity embeded in the code).
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090710/70a7a865/attachment.bin
More information about the samba-technical