the sorry saga of the talloc soname 'fix'

simo idra at samba.org
Thu Jul 9 13:52:43 GMT 2009


On Thu, 2009-07-09 at 15:40 +0200, Volker Lendecke wrote:
> On Thu, Jul 09, 2009 at 08:55:34AM -0400, simo wrote:
> > talloc_steal() would be an especially bad case. If you don't check the
> > return, as it could lead to access to freed memory. Unchecked errors
> > from talloc_free() would lead to memory leaks.
> 
> Wait a second -- talloc_steal() can fail now?????
> 
> How on earth shall we deal with that??

Yes when I realized that I was a bit shocked too.

That's what made me look a bit better at Sam's proposal.

I now think that Sam's proposal is saner than Tridge's solution.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list