optimizations in configure.in

William Jojo w.jojo at hvcc.edu
Sat Jul 4 18:06:08 GMT 2009


I've noticed that the configure script overrides the optimization value selected by build options in 3.2 and 3.3, but has been corrected in 3.4 source3.

Although 3.2 is security patches only and 3.3 is likely bug fixes only at this point since 3.4 is released, these patches make 3.2 and 3.3 more like 3.4:

<samba 3.2 patch>
--- source/configure.in.orig    2009-07-04 13:49:54.000000000 -0400
+++ source/configure.in 2009-07-04 13:50:33.000000000 -0400
@@ -126,8 +126,6 @@
 fi
 if test "x$debug" = "xyes" ; then
        CFLAGS="${CFLAGS} -g"
-else
-       CFLAGS="${CFLAGS} -O"
 fi
 
 CFLAGS="${CFLAGS} -D_SAMBA_BUILD_=3"
</samba 3.2 patch>
------------------------------------------------
<samba 3.3 patch>
--- source/configure.in.orig    2009-07-04 13:55:41.000000000 -0400
+++ source/configure.in 2009-07-04 13:55:55.000000000 -0400
@@ -127,8 +127,6 @@
 fi
 if test "x$debug" = "xyes" ; then
        CFLAGS="${CFLAGS} -g"
-else
-       CFLAGS="${CFLAGS} -O"
 fi
 
 CFLAGS="${CFLAGS} -D_SAMBA_BUILD_=3"
</samba 3.3 patch>


Of course you could always just pull the git patch against 3.4 into 3.3. ;-)


Cheers,
Bill


More information about the samba-technical mailing list