[SCM] Samba Shared Repository - branch master updated -
jra at samba.org
Thu Jul 2 15:51:06 GMT 2009
On Thu, Jul 02, 2009 at 05:28:31PM +0200, Stefan (metze) Metzmacher wrote:
> simo schrieb:
> > Attached a possible patch.
> > NOTE: I am not proposing to push this one, it compiles and should work,
> > but I want to make a few tests on a system using this new talloc with an
> > old samba to confirm it really works.
> > I had 2 choices here, one was to simply always call the new functions,
> > but this would break applications that called talloc_free/talloc_steal
> > against a context that had references. The other was to call the
> > original functions (renamed to _internal) and live with the bugs in
> > older apps.
> > I took the second route because it does not change anything for existing
> > apps, and, as soon as they are recompiled it will be fixed
> > automatically, looks like a sane tradeoff to me, but any comment is very
> > welcome as long as the discussion is polite.
> That patch is exactly what I was proposing (I just was to lazy and only
> made a prototype instead of a full working patch).
> I think we can make _talloc_steal_internal static...
> And we need to allow samba to build against 1.4.0...
> And we should wrap the fprintf statements into #if 0 or #ifdef DEVELOPER.
+1 from me with these changes. Nice work Simo, thanks !
More information about the samba-technical