[QUICK] talloc bugs

[Volker Lendecke]

On Wed, Jul 01, 2009 at 09:20:13PM +0930, Rusty Russell wrote:
> On Mon, 29 Jun 2009 09:19:20 pm tridge at samba.org wrote:
> > Hi Rusty,
> >
> >  > I'd like to see a simple example of where talloc_reference is required,
> >  > so we can get less abstract in this discussion.
> >
> > yep, I've found the abstractness of the discussion unhelpful.
> >
> > Here are two fairly simple examples:
> >
> >  1) in source3/lib/util_tdb.c we have tdb_wrap_open() which is used to
> >  allow us to share a common underlying tdb context between two users,
> >  allowing for the illusion of being able to open a tdb more than once
> >  in the same process. This is a classic case of reference counting.
> 
> This is a classic case of problematic references, too.  Ignoring the fact that 
> TDB should handle multiple opens, there's nothing obviously wrong with:

I'm afraid things are a bit busy for me here. But as I said:
This is on my list to remove the call to talloc_reference.
I am really sorry if this code now causes major hickups in
this discussion.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090701/354c744c/attachment.bin