[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-4877-g910cbc5

Jeremy Allison jra at samba.org
Wed Jan 28 18:16:22 GMT 2009

On Wed, Jan 28, 2009 at 09:21:34AM -0600, Volker Lendecke wrote:
> The branch, v3-3-test has been updated
>        via  910cbc5d6e932fa8ed0066d407a40195b6629a37 (commit)
>        via  3e9c89e81b2915ba1a2aac7b8d72a780f7f9b80e (commit)
>       from  a8a8dde5ac2b0c0b33e49af685650440469b287f (commit)
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
> - Log -----------------------------------------------------------------
> commit 910cbc5d6e932fa8ed0066d407a40195b6629a37
> Author: Volker Lendecke <vl at samba.org>
> Date:   Wed Jan 28 10:35:35 2009 +0100
>     Avoid valgrind errors
>     In event handlers, we might destroy other events that are pending in the lists.
>     We can only run one event safely per select call.
>     Yes, I've seen these valgrind errors :-)
>     Jeremy, with ccdd921e61 you had checked in the change to run multiple events.
>     Do you remember why it was necessary and could not be solved in a different
>     way?

I'm coming to the conclusion that our events API needs an overhaul.

Returning a pointer to the internal event struct is inherently
dangerous due to these problems. What about returning a token
representing the event, and using a search mechanism internal
to the event library to translate between the token and the
desired pointer ?


More information about the samba-technical mailing list