Blocking SIGTERM in nmbd, why?

[Stefan (metze) Metzmacher]

Hi Jeremy,

why do we block SIGTERM in nmbd most of the time?
You added it in 1997, see
http://gitweb.samba.org/?p=samba.git;a=commitdiff;h=d98bea900ee694cdba83149620c65bd7f8765f26

The only reason I can see for this is that the sig_term() function,
really does the shutdown directly at this time, see
http://gitweb.samba.org/?p=samba.git;a=blob;f=source3/nmbd/nmbd.c;h=dc3f642cd6074944de0eb491e4e70c18616c6fc1;hb=d98bea900ee694cdba83149620c65bd7f8765f26

But now that the signal handler only sets the do_sigterm flag,
I can't see the reason why we should still block SIGTERM.

I think removing the signal handler temporary when we do
the interface detection loop is ok for now. But we
should not block SIGTERM the rest of the time.

Please review this commits:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=3aa3a8b6274a11cf27a2df4df97fe011b8b5aa76
http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=0860632d25c19dc111fce5b71d6517fafedf9ec1

They're in this branch:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-tevent2

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090123/b4f729cd/signature.bin