Small buglet in samba 3.2.7 winbindd/idmap_tdb.c

Richard Sharpe realrichardsharpe at gmail.com
Wed Jan 21 06:35:53 GMT 2009


 diff -up samba-3.2.7.orig/source/winbindd/idmap_tdb.c
samba-3.2.7/source/winbindd/idmap_tdb.c
--- samba-3.2.7.orig/source/winbindd/idmap_tdb.c	2008-12-19
05:57:33.000000000 -0800
+++ samba-3.2.7/source/winbindd/idmap_tdb.c	2009-01-20 15:20:40.000000000 -0800
@@ -926,7 +926,8 @@ static NTSTATUS idmap_tdb_set_mapping(st
 	if (tdb_chainlock(ctx->tdb, ksid) != 0) {
 		DEBUG(10,("Failed to lock record %s. Error %s\n",
 				ksidstr, tdb_errorstr(ctx->tdb) ));
-		return NT_STATUS_UNSUCCESSFUL;
+		ret = NT_STATUS_UNSUCCESSFUL;
+		goto done;
 	}

 	data = tdb_fetch(ctx->tdb, ksid);


-- 
Regards,
Richard Sharpe


More information about the samba-technical mailing list