Samba 3.0.32 - internal change notify "legacy" mechanism

[Dina Fine]

Actually I tested this very well, the feature is fully functioning on
our production system cluster wide.
Can you send me diff on your changes? Did you also apply the fix patch?
The feature will not work without some fixes I applied in the notify
inside the samba.

Dina

-----Original Message-----
From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE] 
Sent: Monday, January 19, 2009 6:23 PM
To: Dina Fine
Cc: samba-technical at lists.samba.org; Evgeny Popovich
Subject: Re: Samba 3.0.32 - internal change notify "legacy" mechanism

On Mon, Jan 19, 2009 at 07:56:17AM +0200, Dina Fine wrote:
> I had a bug in the watch of vfs_notify_hash.c - The watch applied on 
> the directory relative path instead of the full path.
> So when samba changed working directory, the watch failed.
> The fix is attached.

What did you actually test? I've ported the module to current master,
but it just did not work for me. I opened a directory from the Windows
explorer, then did a mkdir from the unix side and waited for the timeout
to happen. No update on Windows done. So I wouldn't check it in at this
stage.

Attached find the module for master, I had to modify it slightly and
also did some reformatting to match the Samba coding style with <80
columns.

Volker