[PATCH] Don't send MSG_WINBIND_ONLINE to idmap_child() in any child process

[boyang]

Jeremy Allison wrote:
> On Tue, Jan 13, 2009 at 05:59:39PM +0800, boyang wrote:
>   
>> Hi, everyone:
>>      If the trusted domain cannot go online, fork_child_dc_connect()
>> will be invoked periodically to fork() one child process, trying to
>> connect to DC.  look, fork_child_dc_connect() ---> getdcs() --->
>> get_dc_name_via_netlogon() ---> cm_connect_netlogon() --->
>> init_dc_connection() ---> cm_open_connection ---> set_domain_online(),
>> here send MSG_WINBIND_ONLINE to idmap_child(). It causes
>> MSG_WINBIND_ONLINE being sent to idmap_child() periodically, which cause
>> idmap child to fork and connect to the primary domain'DC even primary
>> domain is already online. :-)  It is very expensive, we must not want to
>> do that....
>>
>> Please review the patches!
>>     
>
> Ok, I've reviewed this very carefully, and I think you're
> correct in this. I've broadened your patch slightly to add
> code to null out the pid on all children after fork, as no
> child should be sending messages to each other, it should
> always go through the parent. Can you check this patch (designed
> for 3-2-test) out and let me know if it works for you (should
> do - it's a simple change to your code).
>
> Once I get confirmation I'll commit to all branhes under
> your name, thanks !
>   
:-) affirmative. It works for me. I have tested it against master. I
post the patch for master in the attachment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: idmap-msg-online-master.diff
Type: text/x-patch
Size: 2000 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090114/846e6a11/idmap-msg-online-master.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yyyeer.bo.vcf
Type: text/x-vcard
Size: 137 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090114/846e6a11/yyyeer.bo.vcf