[PATCH] Don't send MSG_WINBIND_ONLINE to idmap_child() in any child process

Jeremy Allison jra at samba.org
Tue Jan 13 23:32:20 GMT 2009

On Tue, Jan 13, 2009 at 05:59:39PM +0800, boyang wrote:
> Hi, everyone:
>      If the trusted domain cannot go online, fork_child_dc_connect()
> will be invoked periodically to fork() one child process, trying to
> connect to DC.  look, fork_child_dc_connect() ---> getdcs() --->
> get_dc_name_via_netlogon() ---> cm_connect_netlogon() --->
> init_dc_connection() ---> cm_open_connection ---> set_domain_online(),
> here send MSG_WINBIND_ONLINE to idmap_child(). It causes
> MSG_WINBIND_ONLINE being sent to idmap_child() periodically, which cause
> idmap child to fork and connect to the primary domain'DC even primary
> domain is already online. :-)  It is very expensive, we must not want to
> do that....
> Please review the patches!

Ok, this is an optimization I think. It doesn't break
anything sending this message to the idmap child, but
will just cause another connection to the DC.

I'll take a look at this patch, probably worth it to
save resources.

Thanks !


More information about the samba-technical mailing list