[PATCH] TALLOC_FREE(domain->check_online_event) refers to null pointer in winbindd_reinit_after_fork() [Was Re: [PATCH] clean the event context after fork in fork_domain_child()]

[Jeremy Allison]

On Mon, Jan 12, 2009 at 04:16:12PM +0100, Karolin Seeger wrote:
> Hi Jeremy, hi Bo,
> 
> On Sun, Jan 11, 2009 at 11:48:36PM -0800, Jeremy Allison wrote:
> > > After the fix applied, everything works for me very well. :-)
> > 
> > Got it, pushed to 3.2 and 3.0, thanks ! I'm glad you
> > got to your test environment first :-).
> 
> it looks like there are still some issues in this piece of code. Are you
> sure we should ship that with 3.0.34 (which is in maintainance mode) in 8
> days?

I think the issues got fixed by Monday morning.

> In my opinion, it would be a good idea to introduce it with 3.4 as it does
> not fix any regressions.
> 
> What do you think?

The only reason it doesn't specifically fix bugs is that there
were no bugs logged against it :-). These fixes address "intermittent"
winbindd failures which would be *very* difficult to catch in the
normal course of events. Most people would chalk this up to random
failures and just restart winbindd. However these are bad logic bugs
in winbindd we've had for several years. I don't want to ship
another "stable" release without including these logic fixes.

If we need to delay ship to ensure you're happy with the
quality, I'm happy to do so, but I *hate* shipping releases
that I know have logic bugs.

My 2 cents :-).

Jeremy.