Shared Directory parameter for some tdb files
obnox at samba.org
Tue Jan 13 08:55:14 GMT 2009
Andrew Bartlett wrote:
> On Mon, 2009-01-12 at 17:57 -0800, Steven Danneman wrote:
> > > From: Michael Adam [mailto:obnox at samba.org]
> > > Sent: Monday, January 12, 2009 4:03 AM
> > >
> > > Looks very good to me. I pushed your patch to master!
> > >
> > > It is very good that this finally gets sorted out. Thanks!
> > >
> > > I think that this one will be for 3.4.0 though and not for 3.3 since
> > > this is past the rc-stage and packagers have probably adapted their
> > > packaging to 3.3.0 already.
> > Thanks Michael! I just pushed two follow-up patches 7b02e05e and
> > 4a578ec5 to master. I've audited all calls to LOCKDIR, and converted
> > the persistent ones to use state_path().
> > The last step is to audit all calls to lock_path() and lp_lockdir() and
> > decide which one need to be converted to cache_path() and which ones
> > will remain in LOCKDIR. I don't think I'll have time to do this within
> > the week. Do you want to take a first cut and I can CR it for you?
> Isn't this the split that caused the debian FHS patch to stay out of the
> tree for years? With the argument being that we might change a DB from
> temporary to persistent?
Well, iirc, the debian patch introduced the splitting of lockdir
into cachedir and statedir. That we have the (incomplete)
splitting of lockdir now is due to the fact that Christian
Perrier and Steve Langasack have reworked their debian package
fhs-patch for samba in to several units, one or two of which have
been applied to samba upstream. The remaining samba-fhs-patch in
the debian packages makes lockdir unchangeable among other
things. The introduced support for statedir and cachedir in
samba upstream was incomplete in that these options were just
half there (in dynconfig, returning lockdir, unchangeable) in
non-fhs-mode. So the options were there but useless in non-fhs-mode.
Steven has now started the effort of making them real options that
can be changed through configure, loadparm and popt (defaulting to
lockdir) and using statedir and cachedir consistently throughout.
This probably means that the Debian Maintainers will need to
change their patch (e.g. making statedir and cachedir readonly)
but the patch might even become simpler than it is now.
Cheers - Michael
Michael Adam <ma at sernet.de>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 206 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090113/2f350a41/attachment.bin
More information about the samba-technical