[PATCH] clean the event context after fork in fork_domain_child()

boyang boyang at suse.de
Fri Jan 9 09:07:32 GMT 2009


Jeremy Allison wrote:
> On Thu, Jan 08, 2009 at 05:24:23AM +0800, boyang wrote:
>   
>> Jeremy Allison wrote:
>>     
>>> On Wed, Jan 07, 2009 at 05:39:17PM +0100, Stefan (metze) Metzmacher wrote:
>>>   
>>>       
>>>   
>>>       
>> 1. Yes, It doesn't fix any bugs here.
>> 2. No, It causes resource leaks. If the memory is not used by child any
>> more, typiclally winbindd_clients_state() list, why should it be
>> remained?  does it possibly waste memory?
>> tidying thing up is not bad. :-)
>>     
>
> No true, but once we've forked all the original pages
> are left alone unless touched (in which case they have
> to be copy-on-write copied), so changing things we
> don't have to can be *more* wasteful, not less.
>
>   
>>> Back-porting the original fixes to 3.2 or 3.0 is
>>> probably more useful (IMHO).
>>>   
>>>       
>> I'll back port event context  and ticket refresh handler to 3.2 and 3.0
>> as soon as possible. :-)
>>     
Hi, Jeremy && metze:
        Updated version of patch to clean event context and fix krb5
refresh chain, added reference to original commits committed to
v3-3-test, as suggested by metze. Please review it, Thanks!
>
> Thanks !
>
> Jeremy.
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: backport-event-context-and-krb5-refresh-v3-0-test.diff
Type: text/x-patch
Size: 30678 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090109/f9499387/backport-event-context-and-krb5-refresh-v3-0-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: backport-event-context-and-krb5-refresh-v3-2-test.diff
Type: text/x-patch
Size: 29966 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090109/f9499387/backport-event-context-and-krb5-refresh-v3-2-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090109/f9499387/boyang.vcf


More information about the samba-technical mailing list