[PATCH] clean the event context after fork in fork_domain_child()

[boyang]

Jeremy Allison wrote:
> On Wed, Jan 07, 2009 at 05:39:17PM +0100, Stefan (metze) Metzmacher wrote:
>   
>> boyang schrieb:
>>     
>
> Ok, I hate to be negative here, but I don't think this
> patch is needed. The original set of patches were
> essential as they caused actual bugs, in that the
> events were left active and could trigger inappropriately.
>
> This code tidies things up, but except for the fd
> closing doesn't really fix any bugs or resource leaks.
>   
1. Yes, It doesn't fix any bugs here.
2. No, It causes resource leaks. If the memory is not used by child any
more, typiclally winbindd_clients_state() list, why should it be
remained?  does it possibly waste memory?
tidying thing up is not bad. :-)
> Back-porting the original fixes to 3.2 or 3.0 is
> probably more useful (IMHO).
>   
I'll back port event context  and ticket refresh handler to 3.2 and 3.0
as soon as possible. :-)
> Jeremy.
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090108/cb974aa2/boyang.vcf