[PATCH] clean the event context after fork in fork_domain_child()

Stefan (metze) Metzmacher metze at samba.org
Wed Jan 7 16:39:17 GMT 2009

boyang schrieb:
> Stefan (metze) Metzmacher wrote:
>> boyang schrieb:
>>> Jeremy Allison wrote:
>>>> On Tue, Jan 06, 2009 at 01:19:41PM +0800, boyang wrote:
>>>>> Jeremy Allison wrote:
>>>> Ok, I've finished doing a lot of cleanup work on the
>>>> event code in winbindd. It's all checked into 3.3 and
>>>> master. Please review.
>>>> If you feel it's working, feel free to back-port to 3.2
>>>> and/or 3.0.x and I'll commit patches for you. I'm not
>>>> doing that work yet as I'm not sure if we're doing any
>>>> more 3.2.x releases or just moving on to 3.3.0.
>>> Hi, Jeremy:
>>>      Your patch is good. I have done some initial test on it. And I
>>> think we can do some work more to clean the context.
>>> 1*  _client_list or winbindd_client_list() is never used in child,
>>> destroy and free it.
>>> 2* file descriptors come from listen socket in parent, accepted socket
>>> in parent, socket pairs in parent are never used, close it and delete is
>>> from fd_events.
>>> 3* delete all memory credentials too as newly forked child won't use it.
>>> I did some initial test and it works.
>>> Patches are in the attachment, please review it. Thanks!
>>>> Jeremy.
>> Why do you use the deprecated talloc_destroy() ?
> Hi, Jeremy && metze:
>        This is the updated version of the patch.
> 1* Got rid of deprecated talloc_destroy() and use TALLOC_FREE().
> 2* do a test to determine if there is  opened child->event.fd.
> Pleas review it. Thanks!
>> metze

having a close_winbindd_socket_after_fork() just as a one function
should be avoided.

It would be nice if you would format the code like this:

/*                     <-- note this line
 * Long Comment for
 * step2 ....
 */                    <-- and this
                       <-- and this
/* Short Comment for step 2 */

It makes the code much more readable (at least for me:-)

Regarding the functionality I trust Jeremy.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090107/2b4618a8/signature.bin

More information about the samba-technical mailing list