[PATCH] clean the event context after fork in fork_domain_child()

boyang boyang at suse.de
Wed Jan 7 10:47:34 GMT 2009


Jeremy Allison wrote:
> On Tue, Jan 06, 2009 at 01:19:41PM +0800, boyang wrote:
>   
>> Jeremy Allison wrote:
>>     
>
> Ok, I've finished doing a lot of cleanup work on the
> event code in winbindd. It's all checked into 3.3 and
> master. Please review.
>
> If you feel it's working, feel free to back-port to 3.2
> and/or 3.0.x and I'll commit patches for you. I'm not
> doing that work yet as I'm not sure if we're doing any
> more 3.2.x releases or just moving on to 3.3.0.
>   
Hi, Jeremy:
     Your patch is good. I have done some initial test on it. And I
think we can do some work more to clean the context.
1*  _client_list or winbindd_client_list() is never used in child,
destroy and free it.
2* file descriptors come from listen socket in parent, accepted socket
in parent, socket pairs in parent are never used, close it and delete is
from fd_events.
3* delete all memory credentials too as newly forked child won't use it.
I did some initial test and it works.
Patches are in the attachment, please review it. Thanks!
> Jeremy.
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mbox-more-clean-context-master.diff
Type: text/x-patch
Size: 4732 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090107/321bbe83/mbox-more-clean-context-master.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mbox-more-clean-context-v3-3-test.diff
Type: text/x-patch
Size: 4723 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090107/321bbe83/mbox-more-clean-context-v3-3-test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090107/321bbe83/boyang.vcf


More information about the samba-technical mailing list