[PATCH] clean the event context after fork in fork_domain_child()

Jeremy Allison jra at samba.org
Tue Jan 6 05:11:24 GMT 2009


On Tue, Jan 06, 2009 at 01:19:41PM +0800, boyang wrote:

> v2-event-context-master.diff frees check_online_event. But I think you
> don't need it now. Because all events freeing work will be done in
> winbindd_reinit_after_fork() :-). As you said.

Yep, as soon as I've written it :-).

> >> Looks like ccache_regain_all_now relies on entry->refresh_time to judge
> >> whether the handler is krb5_ticket_refresh_handler or
> >> krb5_ticket_gain_handler. Therefore, we must set entry->refresh_time
> >> before event_add_timed to make ccache_regain_all_now work correctly.
> >> I'll post a separate patch later.
> >>     
> >
> > Please send asap so I can evaluate it as I
> > back-port Metze's code to 3.3-test.
> >   
> v2-krb5-refresh-master.diff addresses this. :-) Pls review it, thanks!

Looks good to me, applying to master and 3.3 (now I've brought
it up to date).

Thanks !

Jeremy.


More information about the samba-technical mailing list