[PATCH] clean the event context after fork in fork_domain_child()

boyang boyang at suse.de
Mon Jan 5 12:14:18 GMT 2009


Stefan (metze) Metzmacher wrote:
> Hi BoYang,
>
>   
>>      The point here is that there maybe outstanding requests in parent,
>> and async_request_timeout is set, which cause this child try to kill
>> some other child, probably be primary domain's child. Look, After
>> winbindd started, child for primary domain is forked, then other domains
>> such as BUILTIN. If there are outstanding requests sent to child for
>> primary domain, async_request_timeout handler is set, which is
>> inheritted in child for domain BUILTIN. Later, time expired and child
>> for BUILTIN sends SIGTERM to child for primary domain.
>>      Patches are in the attachment, Thanks!
>>     
>
> I think the real solution is to create a new event context in the child
> process (and free the parents context). In the end we should do that
> also within smbd...
>
> metze
>   
Hi, Metze:
     I've finished the patch to clean event context after fork. Please
review it. In event_context_reinit(ev), I freed all timed_event and
fd_event to save some memory. Initial test and 'make test' looks fine.
     Thanks!

--- BoYang
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1-event-context-master.diff
Type: text/x-patch
Size: 8632 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090105/59dda8a2/v1-event-context-master.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090105/59dda8a2/boyang.vcf


More information about the samba-technical mailing list