[PATCH] Fixes uninitialised access as reported by valgrind.

scudette at gmail.com scudette at gmail.com
Fri Jan 2 11:39:58 GMT 2009


---
 source4/lib/registry/regf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/source4/lib/registry/regf.c b/source4/lib/registry/regf.c
index a869ed4..d6fb413 100644
--- a/source4/lib/registry/regf.c
+++ b/source4/lib/registry/regf.c
@@ -543,7 +543,7 @@ static WERROR regf_get_value(TALLOC_CTX *ctx, struct hive_key *key,
 
 	if (vk->data_length & 0x80000000) {
 		vk->data_length &=~0x80000000;
-		data->data = (uint8_t *)&vk->data_offset;
+		data->data = talloc_memdup(ctx, (uint8_t *)&vk->data_offset, vk->data_length);
 		data->length = vk->data_length;
 	} else {
 		*data = hbin_get(regf, vk->data_offset);
-- 
1.5.4.3



More information about the samba-technical mailing list