[PATCH] tricky bug in idmap_sid_to_uid().

[boyang]

Jeremy Allison wrote:
> On Thu, Feb 26, 2009 at 08:55:13PM +0800, boyang wrote:
>   
>> Hi, everyone:
>>      Please have a look at idmap_sid_to_uid(),
>> idmap_backend_sid_to_unixid() can returns status other than
>> NT_STATUS_NONE_MAPPED or NT_STATUS_OK. eg, NT_STATUS_NO_MEMORY in
>> idmap_tdb_to_id(). This is very faint, SID to UID mapping might exists,
>> but failed only because of lack of memory. Then, idmap_new_mapping()
>> will allocate a new unix id and update SID <--> UID mapping....... which
>> causes inconsistent SID <---> UID mapping. Please correct me if I am wrong.
>>     Patch for master in the attachment, please review it.
>>     Thanks!
>>     
>
> Haven't forgotten about this, just working on the build farm
> breakage at the moment. I'll get to this....
>   
:-) Not a problem. Looks like there are more problems like this. In a
word, some variables are not initialized, but following code relies on
the values to go to different code paths.. I'll get back to you when I
work it out.
> Jeremy.
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: boyang.vcf
Type: text/x-vcard
Size: 187 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20090228/b2544a99/boyang.vcf