latest v4-0-test compilation report (Samba4/OpenChange)

[Jelmer Vernooij]

On Wed, 2009-02-25 at 09:49 -0500, simo wrote:
> On Wed, 2009-02-25 at 09:37 +0100, Stefan (metze) Metzmacher wrote:
> > Volker Lendecke schrieb:
> > > On Wed, Feb 25, 2009 at 08:37:26AM +0100, Stefan (metze) Metzmacher wrote:
> > >> It already includes stdint.h, so just stdbool.h is missing.
> > >>
> > >> libreplace autogenerates both in case the system doesn't have them.
> > > 
> > > Wait -- we *generate* stdint.h and stdbool.h??
> > 
> > yes, look for LIBREPLACE_PROVIDE_HEADER() in lib/replace/*.m4
> > 
> > If the system doesn't have them, we generate lib/replace/stdint.h as:
> > #include "replace.h"
> 
> Why ? Can't you just use defines to conditionally include stdint.h in
> replace.h  ?
> 
> Why are we actually creating header files ? 
> I know they are private and we do not install them but I don't get it.
So we can just include C99 headers without worrying about broken systems
everywhere.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20090225/5107becb/attachment.bin