[PATCH] reduce fd usage in smbd

Stefan (metze) Metzmacher metze at samba.org
Wed Feb 25 00:31:21 MST 2009


Andrew Bartlett schrieb:
> On Tue, 2009-02-24 at 18:23 -0800, Dan Sledz wrote:
>> >From the patch description:
>>
>>  
>>
>> It seems we are calling tdb_reopen_all for two reasons:
>>
>> The first reason is to make sure we get a new seek pointer.  
>> The second reason has to do with the TDB_CLEAR_IF_FIRST flag.  
> 
> Surely there are also locking interactions here?
> 
> All I know is that POSIX locking is insane, and I wouldn't want to
> change this without considering this in particular.

If there're no locking issues I would propose this:
http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=7648b8f94c0709f39b873b872bc1273a6568ad3b

It makes tdb_reopen_all() a noop.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20090225/23e24895/signature.bin


More information about the samba-technical mailing list