[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-1097-gcf7539a

[Derrell Lipman]

On Mon, Feb 23, 2009 at 4:23 PM, Jeremy Allison <jra at samba.org> wrote:

> On Mon, Feb 23, 2009 at 12:50:53PM -0600, Derrell Lipman wrote:
> > The branch, master has been updated
> >        via  cf7539abfb0f6e6956bed7a478e0cda6ab734674 (commit)
> >       from  ca24822234d9dc77dbe3f351d6dbab5558efac39 (commit)
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit cf7539abfb0f6e6956bed7a478e0cda6ab734674
> > Author: Derrell Lipman <derrell.lipman at unwireduniverse.com>
> > Date:   Mon Feb 23 13:50:11 2009 -0500
> >
> >     Make char* parameters const
> >
> >     - Use const in function signatures whenever appropriate, to help
> prevent
> >       errant scribbling on users' buffers. smbc_set_credentials() always
> acted as
> >       if its formal parameters were const char *, and changing the formal
> >       declaration to specify that should not cause any change to the ABI.
> It is
> >       still allowable to pass a writable buffer to a function which
> specifies that
> >       it will not write to the buffer.
> >
> >       I'm making this change only in master.
>
> Derrell, I think this change needs to be in 3.3 also (IMHO).
>

Isn't 3.3 about to be released? Since this change has no functional effect,
I figured it made no sense to make a change this close to a release that
doesn't actually solve a problem. I was inclined to just let it be part of
3.4. I'll make the change if you want, or I can make it after the
(tomorrow?) release, or it could just be for the 3.4 release from master.
Make an executive decision :-) and I'll add it as requested.

Derrell