[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-1106-gbcd6e5e

Guenther Deschner gd at samba.org
Mon Feb 23 17:51:44 MST 2009

Jeremy Allison wrote:
> On Mon, Feb 23, 2009 at 06:11:55PM -0600, Günther Deschner wrote:
>> The branch, master has been updated
>>        via  bcd6e5ec3315b14cedf7437a70c34d233ded082e (commit)
>>       from  3e796103b28f1279bdaa481b7d5c4447d62683bb (commit)
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>> - Log -----------------------------------------------------------------
>> commit bcd6e5ec3315b14cedf7437a70c34d233ded082e
>> Author: Günther Deschner <gd at samba.org>
>> Date:   Mon Feb 23 11:43:32 2009 +0100
>>     s3-spoolss: fix notify_printer_status_byname.
>>     This took me almost a week to find, so here a little longer explanation:
>>     When a windows client registers printer *status* change notifies using
>>     spoolss_RemoteFindFirstChangeNotify, it registers them to a print server handle,
>>     not a printer handle. We were then correctly monitoring the printer status
>>     changes but were sending out the spoolss_RouterReplyPrinterEx via the back-channel
>>     connection with job_id set to 0 (which we only may do for monitored printer
>>     change status notifies on printer handlers, not print server handles). Windows
>>     was then showing a new empty dummy printer icon in the explorer as it cannot
>>     route the notify event to the approriate local handle. It also discarded the
>>     content of the notify event message of course. With this, printer change notify for
>>     pausing, resuming and purging printers nicely works again here.
>>     Jerry, Tim and all other printing gurus, please check.
> Guenther, can you push this back to 3.3 and 3.3 please ?

I can, but in 3.3 and 3.2 the parsing of the
spoolss_RouterRefreshPrinterChangeNotify reply struct is broken so that
windows immediately shuts down the backchannel connection and we never
can send out change notifies. So this fix alone won't do it.

Hm, are you asking me to backport the spoolss fixes from master back
into 3-3/3-2 rpc_parse/parse_spools.c style ?? Please no :-)

Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner at redhat.com
Samba Team                              gd at samba.org

More information about the samba-technical mailing list