[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-1106-gbcd6e5e

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Günther,

> commit bcd6e5ec3315b14cedf7437a70c34d233ded082e
> Author: Günther Deschner <gd at samba.org>
> Date:   Mon Feb 23 11:43:32 2009 +0100
> 
>     s3-spoolss: fix notify_printer_status_byname.
>     
>     This took me almost a week to find, so here a little longer explanation:
>     
>     When a windows client registers printer *status* change notifies using
>     spoolss_RemoteFindFirstChangeNotify, it registers them to a print server handle,
>     not a printer handle. We were then correctly monitoring the printer status
>     changes but were sending out the spoolss_RouterReplyPrinterEx via the back-channel
>     connection with job_id set to 0 (which we only may do for monitored printer
>     change status notifies on printer handlers, not print server handles). Windows
>     was then showing a new empty dummy printer icon in the explorer as it cannot
>     route the notify event to the approriate local handle. It also discarded the
>     content of the notify event message of course. With this, printer change notify for
>     pausing, resuming and purging printers nicely works again here.
>     
>     Jerry, Tim and all other printing gurus, please check.

Makes sense to me.  Nice catch.



cheers, jerry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmjPNYACgkQIR7qMdg1EfbIIwCguFcFY/rek/XBHdH7EpN4JGs/
UtIAnAi3XsQjC2RGzRZ+XIvUE2IzGQOV
=qyfJ
-----END PGP SIGNATURE-----